Couple to Kynema for ALM and templatize existing OpenFAST interface #1759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
At this point, the templates for OpenFAST are basically done, though they will probably be tweaked later in the process. Both act_uniform_alm reg tests pass! |
still need to copy to kynema, convert orientation, make mapping calls etc.
Contributor
Author
|
Derek Slaughter already looked over the Kynema interface calls |
marchdf
reviewed
Nov 19, 2025
marchdf
reviewed
Nov 19, 2025
marchdf
approved these changes
Nov 19, 2025
Contributor
marchdf
left a comment
marchdf
left a comment
There was a problem hiding this comment.
Amazing work! Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Needed to implement coupling with Kynema as an aero + turbine model. To avoid duplicating code and to ensure I was doing the right things, I templated the existing OpenFAST interface and made the Kynema interface another specialization of that template. Kynema does a lot less "under the hood" compared to OpenFAST, especially for initialization, so the template specialization is much more involved. The *Iface.cpp and *_types.H files are the main ones that have to be changed depending on the template; the others are simpler and mostly for instantiation.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: